Fix heredoc comma issue #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: when trailing commas are wanted we put them into the wrong place for heredocs.
Why: So that trailing comma config is respected.
splattael
requested changes
Nov 20, 2017
| # This is needed so that we can add a comma if one is not already present. | ||
| captured_output = capture_output { next_token } | ||
|
|
||
| inside_literal_elements_list = !@literal_elements_level.nil? && |
There was a problem hiding this comment.
Should we initialize @literal_elements_level in the initialize method similar to @node_level?
There was a problem hiding this comment.
Good call. I have fixed this up.
mjago
approved these changes
Nov 20, 2017
|
Any other thoughts on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61.